Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support commands with spaces #239

Merged
merged 2 commits into from Feb 10, 2022
Merged

Conversation

mdonnalley
Copy link
Contributor

Support tests for commands that use spaces

@W-10663692@

@mdonnalley mdonnalley self-assigned this Feb 8, 2022
peternhale
peternhale previously approved these changes Feb 8, 2022
src/load-config.ts Outdated Show resolved Hide resolved
@@ -5,7 +5,7 @@ import {Interfaces, Config} from '@oclif/core'
* @param {loadConfig.Options} opts options
* @return {Promise<Interfaces.Config>} config
*/
export function loadConfig(opts: loadConfig.Options = {}) {
export function loadConfig(opts: loadConfig.Options = {}): { run(ctx: { config: Interfaces.Config}): Promise<Interfaces.Config> } {
Copy link
Contributor

@peternhale peternhale Feb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's gnarly :).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah... lol. I didn't even know you could do this.

@peternhale peternhale merged commit f5cf36f into main Feb 10, 2022
@peternhale peternhale deleted the mdonnalley/support-spaces branch February 10, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants