Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update indent-string to ^4.0.0 (from ^3.2.0) #55

Merged
merged 1 commit into from Dec 13, 2019
Merged

chore: update indent-string to ^4.0.0 (from ^3.2.0) #55

merged 1 commit into from Dec 13, 2019

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Nov 9, 2019

This removes the need for @types/indent-string, and allows better deduplication.

@codecov
Copy link

codecov bot commented Nov 9, 2019

Codecov Report

Merging #55 into master will decrease coverage by 74.53%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #55       +/-   ##
========================================
- Coverage   74.53%    0%   -74.54%     
========================================
  Files           7     1        -6     
  Lines         271     7      -264     
  Branches       81     0       -81     
========================================
- Hits          202     0      -202     
+ Misses         32     7       -25     
+ Partials       37     0       -37
Impacted Files Coverage Δ
src/commands/help.ts 0% <0%> (-73.34%) ⬇️
src/index.ts
src/util.ts
src/list.ts
src/screen.ts
src/root.ts
src/command.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a0c4db...a35c77a. Read the comment docs.

@G-Rath
Copy link
Contributor Author

G-Rath commented Dec 12, 2019

@RasPhilCo any chance of getting this merged? It would be a nice clean win to get everything updated to the latest of indent-string for max deduplication, especially since it's unlikely to see any new majors 🙂

@RasPhilCo RasPhilCo merged commit 8cd47e0 into oclif:master Dec 13, 2019
@G-Rath
Copy link
Contributor Author

G-Rath commented Dec 13, 2019

@RasPhilCo cheers! Would you be happy if I did the same for semver across the oclif projects? It's currently on 5, and the latest is 6, and it's a pretty well used package.

I've also noticed at least one repo uses cli-ux@4 instead of 5 😬

I guess the better question is: are you happy w/ someone making a bunch of package updates across oclif?

@G-Rath G-Rath deleted the update-indent-string branch December 13, 2019 20:34
@RasPhilCo
Copy link
Contributor

@G-Rath that'd be great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants