Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix print "undefined" #52

Merged
merged 2 commits into from Dec 3, 2019
Merged

Fix print "undefined" #52

merged 2 commits into from Dec 3, 2019

Conversation

Skriptach
Copy link
Contributor

Before
image

After
image

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @Skriptach to sign the Salesforce.com Contributor License Agreement.

@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #52 into master will decrease coverage by 74.53%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #52       +/-   ##
========================================
- Coverage   74.53%    0%   -74.54%     
========================================
  Files           7     1        -6     
  Lines         271     7      -264     
  Branches       81     0       -81     
========================================
- Hits          202     0      -202     
+ Misses         32     7       -25     
+ Partials       37     0       -37
Impacted Files Coverage Δ
src/commands/help.ts 0% <0%> (-73.34%) ⬇️
src/list.ts
src/root.ts
src/screen.ts
src/util.ts
src/command.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4595694...b6eaa7d. Read the comment docs.

@RasPhilCo
Copy link
Contributor

Interesting! What shell are you using in the screen shot?

@Skriptach
Copy link
Contributor Author

Node from Electron

@RasPhilCo
Copy link
Contributor

RasPhilCo commented Nov 27, 2019

@Skriptach I merged in some master changes that were blocking this. Let me know when you get a chance to sign the CLA and then I can merge this.

@Skriptach
Copy link
Contributor Author

Skriptach commented Nov 28, 2019

@RasPhilCo

sign the CLA

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants