Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: .deb packing privileges #987

Merged
merged 1 commit into from Oct 20, 2022
Merged

Conversation

Vesther
Copy link
Contributor

@Vesther Vesther commented Oct 4, 2022

Currently unable to run the debian packing as a non-root user indepentend of sudo privileges.
Because the chown and chgrp are used for the root group anyway, this is my suggested fix for now.

Relevant: #887

@salesforce-cla
Copy link

salesforce-cla bot commented Oct 4, 2022

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Kevin Nowald <k***@n***.pl>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

@Vesther
Copy link
Contributor Author

Vesther commented Oct 4, 2022

Also @salesforce-cla bot, that email is on my GitHub account 🤔

@mdonnalley mdonnalley merged commit 5392841 into oclif:main Oct 20, 2022
@jurajseffer
Copy link

I've ended up removing those two lines completely as sudo won't work in containers that don't have it installed.

gaelmotte pushed a commit to gaelmotte/oclif that referenced this pull request Oct 24, 2022
@jdx
Copy link
Contributor

jdx commented Nov 10, 2022

huh did I write this code? Seems weird that I made it so sudo was required.

In any case, I think @jurajseffer makes a good point—we can't rely on sudo being installed. I wonder if the --root-owner-group flag could be used here to make this step not necessary.

@Vesther Vesther deleted the fix/debian-pack-sudo branch November 15, 2022 16:07
@lukepolo
Copy link

lukepolo commented Jan 5, 2023

was this reverted? its requiring it again .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants