Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Windows batch scripts to handle Ctrl+C better #958

Open
riywo opened this issue Sep 15, 2022 · 0 comments
Open

[Feature request] Windows batch scripts to handle Ctrl+C better #958

riywo opened this issue Sep 15, 2022 · 0 comments
Labels
help wanted Accepting PRs windows Windows-only issue

Comments

@riywo
Copy link

riywo commented Sep 15, 2022

What is the current behavior?

Not a bug but it's annoying when we implement a command running an external agent from our CLI and keep running it until the user hit "Ctrl+C". On Windows, since oclif's batch scripts naively execute Node.js program, Ctrl+C always asks the user to terminate the job like below:

PS C:\Users\ryosuke.iwanaga> autify connect client start
... 
(Hit Ctrl+C)
Terminate batch job (Y/N)? y

What is the expected behavior?

No confirmation like Linux or macOS.

We implemented a patch for this solution. If you feel this is the right approach, we can send a PR with a flag or environmental variable for oclif pack tarball and oclif pack win to enable these new script optionally. We also need the similar one in @oclif/plugin-update.

Patches:

https://github.com/autifyhq/autify-cli/blob/12e2191aa93ae04a640153b651dd92ba8b1429d6/patches/oclif%2B3.2.28.patch
https://github.com/autifyhq/autify-cli/blob/12e2191aa93ae04a640153b651dd92ba8b1429d6/patches/%40oclif%2Bplugin-update%2B3.0.7.patch

@riywo riywo changed the title [Feature request] New Windows batch script to handle Ctrl+C better [Feature request] Windows batch scripts to handle Ctrl+C better Sep 15, 2022
@mdonnalley mdonnalley added help wanted Accepting PRs windows Windows-only issue labels Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Accepting PRs windows Windows-only issue
Projects
None yet
Development

No branches or pull requests

2 participants