Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI issue: environment variables are missing resulting in false test failures #951

Closed
shazron opened this issue Sep 5, 2022 · 2 comments

Comments

@shazron
Copy link
Contributor

shazron commented Sep 5, 2022

Description

The CI tests by CircleCI are failing because of missing environment variables. Something changed in the CircleCI project configuration that is resulting in false test failures.

Example PR: #925
PR Jobs: https://app.circleci.com/pipelines/github/oclif/oclif?branch=pull%2F925

Failure

https://app.circleci.com/pipelines/github/oclif/oclif/3898/workflows/87dc5684-4653-4499-988b-d005977c5028/jobs/45905

Screenshot 2022-09-05 at 5 25 34 PM

Success

https://app.circleci.com/pipelines/github/oclif/oclif/3714/workflows/a9902f92-3a9c-4b80-b1ee-6fbe75561579/jobs/45780

Screenshot 2022-09-05 at 5 24 54 PM

@mdonnalley
Copy link
Contributor

@shazron We've turned off the Pass secrets to builds from forked pull requests setting in CircleCI turned off for security purposes.

@shazron
Copy link
Contributor Author

shazron commented Sep 7, 2022

@mdonnalley I would humbly suggest that the integration tests not be run on pull requests then, if only as a sanity check for you as an open source maintainer to quickly filter out signal from noise in submitted PRs, if not every PR will always fail...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants