Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: readme for single command cli #916

Merged
merged 1 commit into from Jul 15, 2022
Merged

fix: readme for single command cli #916

merged 1 commit into from Jul 15, 2022

Conversation

mdonnalley
Copy link
Contributor

Fixes readme output for single command CLIs

Fixes #915

@mdonnalley mdonnalley self-assigned this Jul 14, 2022
peternhale
peternhale approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@peternhale peternhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdonnalley Is there a test to cover the change?

@mdonnalley
Copy link
Contributor Author

@mdonnalley Is there a test to cover the change?

@peternhale Currently there are no unit tests covering this command (actually, there are multiple commands with no test coverage). I'd rather take that effort on in a separate work item

@mdonnalley mdonnalley merged commit 242b34f into main Jul 15, 2022
@mdonnalley mdonnalley deleted the mdonnalley/single-cli-readme branch July 15, 2022 15:49
gaelmotte pushed a commit to gaelmotte/oclif that referenced this pull request Oct 24, 2022
@mdonnalley
fix: readme for single command cli (oclif#916)
88c4b38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternhale peternhale peternhale approved these changes

@RodEsp RodEsp Awaiting requested review from RodEsp

Assignees

@mdonnalley mdonnalley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oclif readme for single command CLIs produces wrong output
2 participants
@mdonnalley @peternhale