Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build/pack in parallel #914

Merged
merged 1 commit into from Jul 7, 2022
Merged

feat: build/pack in parallel #914

merged 1 commit into from Jul 7, 2022

Conversation

mshanemc
Copy link
Member

@mshanemc mshanemc commented Jul 6, 2022

add a --parallel option to the pack command to speed things along.

local packing on 2.4 GHz 8-Core Intel Core i

original: 9m58s
--parallel: 3m17s

@@ -13,6 +13,7 @@ This can be used to create oclif CLIs that use the system node or that come prel
root: Flags.string({char: 'r', description: 'path to oclif CLI root', default: '.', required: true}),
targets: Flags.string({char: 't', description: 'comma-separated targets to pack (e.g.: linux-arm,win32-x64)'}),
xz: Flags.boolean({description: 'also build xz', allowNo: true}),
parallel: Flags.boolean({description: 'build tarballs in parallel'}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason not to have parallel as the default? Why would anyone prefer to run them sequentially?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only did this to avoid breaking changes in people's scripts [imagine someone using free CI tier with smaller vm/ lower memory]

@mdonnalley
Copy link
Contributor

mdonnalley commented Jul 7, 2022

@mshanemc if we merge this into main then it'll be released in v3, which is not being used by sf or sfdx. You can see W-10989572 for more but the gist is that v3 adds support for M1 builds, which would require us to make a handful of changes in our release process.

So if you want this feature before we do all that work, we'll need to create a v2 branch and merge that change there.

Update: we decided to go ahead and do that while you're out

@mdonnalley mdonnalley merged commit d86c722 into main Jul 7, 2022
@mdonnalley mdonnalley deleted the sm/parallel-pack branch July 7, 2022 15:07
mdonnalley pushed a commit that referenced this pull request Jul 7, 2022
gaelmotte pushed a commit to gaelmotte/oclif that referenced this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants