Fix tarball packing in paths with spaces #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimterry
force-pushed
the
fix-pack-with-spaces
branch
from
af1a912
to
8e9d110
Compare
|
Seems that the build failures are just because |
mdonnalley
added a commit
that referenced
this pull request
Feb 9, 2022
gaelmotte
pushed a commit
to gaelmotte/oclif
that referenced
this pull request
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces oclif/dev-cli#416.
This PR just adds quotes around a few raw paths used during tarball packing, ensuring that these steps work when run in a path containing spaces.
I've tested this in my project, and everything now seems to build correctly when running
oclif pack tarballs.