Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make oclif.s3.folder optional for --indexes #1063

Merged
merged 1 commit into from Dec 27, 2022
Merged

fix: make oclif.s3.folder optional for --indexes #1063

merged 1 commit into from Dec 27, 2022

Conversation

mshanemc
Copy link
Member

folder property on pjson.oclif.s3 was being used by the --indexes but wasn't being checked for.

fix #1062

Now, it's optional

@cristiand391 cristiand391 merged commit df9db2f into main Dec 27, 2022
@cristiand391 cristiand391 deleted the sm/indexes-require-folder branch December 27, 2022 13:28
mattwebbio pushed a commit to appfolio/oclif that referenced this pull request Dec 29, 2022
@mshanemc @mattwebbio
fix: make oclif.s3.folder optional for --indexes (oclif#1063)
816a0e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiand391 cristiand391 cristiand391 approved these changes

@peternhale peternhale peternhale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create version indexes .json file
3 participants
@mshanemc @cristiand391 @peternhale