Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

'See code' links to GitHub won't work in Typescript monorepo #470

Open
JaimeObregon opened this issue Jan 9, 2022 · 0 comments
Open

'See code' links to GitHub won't work in Typescript monorepo #470

JaimeObregon opened this issue Jan 9, 2022 · 0 comments

Comments

@JaimeObregon
Copy link

This way of checking for a TypeScript repository in the readme command is fragile:

    if (plugin.pjson.devDependencies && plugin.pjson.devDependencies.typescript) {

In a TypeScript monorepo using workspaces, typescript can be defined at the root package's devDependencies, where plugin.pjson.devDependencies.typescript wont reach.

In my setup this is causing to silently miss all the links to see the source in GitHub, but this seems to be provoking #126 and #143 too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant