From 55f225819658ae00b545ac87f9e6a4719e6ecc2c Mon Sep 17 00:00:00 2001 From: Mike Donnalley Date: Thu, 14 Jul 2022 10:05:42 -0600 Subject: [PATCH 1/3] feat: add stderr method --- src/command.ts | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/command.ts b/src/command.ts index 1e72c5166..7b51ef410 100644 --- a/src/command.ts +++ b/src/command.ts @@ -199,14 +199,24 @@ export default abstract class Command { return Errors.error(input, options as any) } - log(message = '', ...args: any[]): void { + stdout(message = '', ...args: any[]): void { if (!this.jsonEnabled()) { - // tslint:disable-next-line strict-type-predicates message = typeof message === 'string' ? message : inspect(message) process.stdout.write(format(message, ...args) + '\n') } } + stderr(message = '', ...args: any[]): void { + if (!this.jsonEnabled()) { + message = typeof message === 'string' ? message : inspect(message) + process.stderr.write(format(message, ...args) + '\n') + } + } + + log(message = '', ...args: any[]): void { + this.stdout(message, args) + } + public jsonEnabled(): boolean { return this.ctor.enableJsonFlag && this.argv.includes('--json') } From 19e06a08f75cfc46f50f5868ae180d5569968967 Mon Sep 17 00:00:00 2001 From: Mike Donnalley Date: Thu, 14 Jul 2022 10:17:02 -0600 Subject: [PATCH 2/3] chore: fix tests --- src/command.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/command.ts b/src/command.ts index 7b51ef410..674264011 100644 --- a/src/command.ts +++ b/src/command.ts @@ -214,7 +214,7 @@ export default abstract class Command { } log(message = '', ...args: any[]): void { - this.stdout(message, args) + this.stdout(message, ...args) } public jsonEnabled(): boolean { From 5ac16a982a39c4e8772c6b10895d4e049bd5af5c Mon Sep 17 00:00:00 2001 From: Mike Donnalley Date: Fri, 15 Jul 2022 13:58:19 -0600 Subject: [PATCH 3/3] chore: code review --- src/command.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/command.ts b/src/command.ts index 674264011..5bbdeb1a8 100644 --- a/src/command.ts +++ b/src/command.ts @@ -199,24 +199,20 @@ export default abstract class Command { return Errors.error(input, options as any) } - stdout(message = '', ...args: any[]): void { + log(message = '', ...args: any[]): void { if (!this.jsonEnabled()) { message = typeof message === 'string' ? message : inspect(message) process.stdout.write(format(message, ...args) + '\n') } } - stderr(message = '', ...args: any[]): void { + logToStderr(message = '', ...args: any[]): void { if (!this.jsonEnabled()) { message = typeof message === 'string' ? message : inspect(message) process.stderr.write(format(message, ...args) + '\n') } } - log(message = '', ...args: any[]): void { - this.stdout(message, ...args) - } - public jsonEnabled(): boolean { return this.ctor.enableJsonFlag && this.argv.includes('--json') }