allow flags to have false value in when

[MichaelGoberling]

We have certain scenarios where we want to disallow users from using a --no flag when another flag is present. It seems we can do this by checking the value of the flag we want to disallow in when, but it ignores false values.

Flags

action: Flags.string({ 
    description: "Deploy a specific action", 
    exclusive: [{ name: 'actions', when: async (flags) => flags.actions === false }] 
}),
actions Flags.boolean({ 
    description: "Deploy actions", 
    allowNo: true 
})

Execution

bin/run app deploy --action=a --no-actions
<success>

With this PR, the above will throw an error.

The following error occurred:
  --actions=false cannot also be provided when using --action
See more help with --help

Related Issue

Closes #556

Currently a draft PR, because this was added without any tests failing and only one case has been added.

[salesforce-cla]

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Michael Goberling <m***@m***.local>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

[MichaelGoberling]

After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

Signed 👍

[MichaelGoberling]

@mdonnalley Thanks for taking a look at this!

Added a new failure test case. CLA has been signed and the commits have been updated with a valid author 👍

[MichaelGoberling]

@mdonnalley CLA has been signed. I may have confused the bot with the force push to fix the commit authors.

[cristiand391]

hey @MichaelGoberling 👋🏼 ,is this ready for review? if so please update the PR as it is marked as draft and can't be merged.

[MichaelGoberling]

Hey @cristiand391 👋 Yup! This is ready for review now.

[cristiand391]

@oclif/core@1.23.0 was published with this fix, thanks @MichaelGoberling for contributing :)