Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only output help for subcommands, no aliases #492

Merged
merged 2 commits into from Sep 16, 2022

Conversation

purplecabbage
Copy link
Contributor

We have commands with a lot aliases, lately this means help text looks like this:

bin/run app add --help
...
COMMANDS
  app add action      Add new actions
  app add actions     Add new actions
  app add event       Add a new Adobe I/O Events action
  app add events      Add a new Adobe I/O Events action
  app add ext         Add new extensions or a standalone application to the project
  app add extension   Add new extensions or a standalone application to the project
  app add extensions  Add new extensions or a standalone application to the project
  app add service     Subscribe to Services in the current Workspace
  app add services    Subscribe to Services in the current Workspace

with this pr, it looks like:

COMMANDS
  app add action      Add new actions
  app add event       Add a new Adobe I/O Events action
  app add extension   Add new extensions or a standalone application to the project
  app add service     Subscribe to Services in the current Workspace

This is currently a draft because I was able to add/change this code without breaking any tests, so likely we are missing some tests for help output.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @purplecabbage to sign the Salesforce.com Contributor License Agreement.

@purplecabbage
Copy link
Contributor Author

Thanks for the contribution! Before we can merge this, we need @purplecabbage to sign the Salesforce.com Contributor License Agreement.

Done!

Copy link
Contributor

@mdonnalley mdonnalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the aliases started showing up in the help output after we merged changes to support flexible taxonomy. So thanks for fixing the regression @purplecabbage

Looks like you just need to update the branch with main before I can merge it.

Thanks!

@purplecabbage purplecabbage marked this pull request as ready for review September 16, 2022 17:56
@purplecabbage
Copy link
Contributor Author

Done. This is ready now thanks.

@mdonnalley mdonnalley merged commit e92674d into oclif:main Sep 16, 2022
@purplecabbage purplecabbage deleted the NoAliases branch September 16, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants