Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean flags don't read environment variables #487

Closed
justinwyer opened this issue Sep 8, 2022 · 0 comments · Fixed by #488
Closed

Boolean flags don't read environment variables #487

justinwyer opened this issue Sep 8, 2022 · 0 comments · Fixed by #488

Comments

@justinwyer
Copy link
Contributor

Describe the bug
Boolean flags do not read environment variables.

To Reproduce
Steps to reproduce the behavior:
Create a command with a boolean flag and try use an environment variable to enable the flag.

Expected behavior
It is possible to pass the env option to a boolean flag, so boolean flags should take env variables into consideration and check them for truthy values.
justinwyer pushed a commit to justinwyer/oclif-core that referenced this issue Sep 8, 2022
fix: support environment variables for boolean flags
4be1082 
fixes oclif#487

I am happy to contribute to the docs if this is accepted.
@justinwyer justinwyer mentioned this issue Sep 8, 2022
Merged
justinwyer pushed a commit to justinwyer/oclif-core that referenced this issue Sep 8, 2022
@justinwyer
fix: support environment variables for boolean flags
ee5cac3 
fixes oclif#487

I am happy to contribute to the docs if this is accepted.
justinwyer added a commit to justinwyer/oclif-core that referenced this issue Sep 8, 2022
@justinwyer
fix: support environment variables for boolean flags
8350aee 
fixes oclif#487

I am happy to contribute to the docs if this is accepted.
mdonnalley pushed a commit that referenced this issue Sep 8, 2022
@justinwyer
fix: support environment variables for boolean flags (#488)
b3d9146 
fixes #487

I am happy to contribute to the docs if this is accepted.
@mdonnalley mdonnalley mentioned this issue Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support environment variables for boolean flags justinwyer/oclif-core
1 participant
@justinwyer