Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of how
globalFlags
is typed, if you do not define any global flags then theflags
returned fromCommand.parse
will include{ [flag: string]: unknown }
, which prevents typescript from erroring when you're attempting to access a non-existent flag.This PR changes the default type for
flags
andglobalFlags
from{ [flag: string]: unknown }
toobject
. Doing so removes the index signature and allows typescript to fail when accessing a non-existent flag. Unfortunately, this requires using theobject
type which is discouraged.The alternative to this wrapping the returned flags in a new generic type that removes the index signature,
This also solves the problem but it slightly obscures what the actual flags are, e.g.