feat: support TS directory imports for ESM #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
suggested changes
May 20, 2022
| @@ -13,7 +13,7 @@ const getPackageType = require('get-package-type') | |||
| * Defines file extension resolution when source files do not have an extension. | |||
| */ | |||
| // eslint-disable-next-line camelcase | |||
| const s_EXTENSIONS: string[] = ['.js', '.mjs', '.cjs'] | |||
| const s_EXTENSIONS: string[] = ['.ts', '.js', '.mjs', '.cjs'] | |||
There was a problem hiding this comment.
Should .jsx or .tsx file extensions be included?
There was a problem hiding this comment.
@peternhale aren't .jsx and .tsx files specific to react development?
There was a problem hiding this comment.
Yes. Anything in oclif that prevents one from using react?
There was a problem hiding this comment.
@peternhale I just don't see the use case for using jsx syntax in a CLI. I'd rather not support it until someone comes along with a convincing use case
There was a problem hiding this comment.
I definitely want to play around with https://github.com/vadimdemedes/ink at some point. Might add it then 😄
peternhale
approved these changes
May 20, 2022
RodEsp
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ESM module resolution for typescript directories
Fixes #421