Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve algo for collating command id #415

Merged
merged 4 commits into from May 10, 2022
Merged

fix: improve algo for collating command id #415

merged 4 commits into from May 10, 2022

Conversation

mdonnalley
Copy link
Contributor

Improve the function used for deciphering the command id from the argv.

This improves the experience when executing commands with args in flexible taxonomy mode.

[skip-validate-pr]

@mdonnalley mdonnalley self-assigned this May 4, 2022
cristiand391
cristiand391 approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@cristiand391 cristiand391 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR linked sf finds the correct command when passing args to config get:

Screen Shot 2022-05-09 at 13 52 53

@mdonnalley mdonnalley merged commit 1a9bfdb into main May 10, 2022
@mdonnalley mdonnalley deleted the mdonnalley/tax-free-with-args branch May 10, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiand391 cristiand391 cristiand391 approved these changes

@RodEsp RodEsp Awaiting requested review from RodEsp

@peternhale peternhale Awaiting requested review from peternhale

Assignees

@mdonnalley mdonnalley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdonnalley @cristiand391