New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: POC for allowing flexible command taxonomy #376
Conversation
c602ddd
to
53226b1
Compare
017930a
to
ed4301a
Compare
src/config/util.ts
Outdated
return getPerumtations(commandId.split(':')).flatMap(c => c.join(':')) | ||
} | ||
|
||
export function collectUsableParts(items: string[]): string[] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdonnalley comments please for future generations
a520509
to
869b42b
Compare
Co-authored-by: Rodrigo Espinosa de los Monteros <1084688+RodEsp@users.noreply.github.com>
305066e
to
aea6b89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA
Almost everything looks good except for the last two issue listed about topic help no longer showing up.
This was all tested using test-cli, expand this for command structure.
console.log()
.✔️ Run .\bin\dev.cmd hello
-> Get error saying missing required arg
✔️ Run .\bin\dev.cmd hello Tester
-> Get error saying missing required flag
✔️ Run .\bin\dev.cmd hello Tester -f Me
-> Get successful command output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA - Round 2
This was all tested using test-cli, expand this for command structure.
console.log()
.Every ✔️ from previous QA is still ✔️.
✔️ --help
flag works as expected on topics
Allowing flexible command taxonomy if the
flexibleTaxonomy
property in the oclif config is set to trueExamples