fix: update isProd utility #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
approved these changes
Feb 9, 2022
|
Thanks 👍 |
RodEsp
reviewed
Feb 9, 2022
| @@ -37,5 +37,5 @@ export function castArray<T>(input?: T | T[]): T[] { | |||
| } | |||
|
|
|||
| export function isProd() { | |||
| return process.env.NODE_ENV !== 'development' | |||
| return !['development', 'test'].includes(process.env.NODE_ENV ?? '') | |||
There was a problem hiding this comment.
Can we please try to err on the side of more readable code?
I would much rather see something like return process.env.NODE_ENV !== 'development' && process.env.NODE_ENV !== 'test'. It's so much easier to parse what exactly that code does and intends to do than something like this.
There was a problem hiding this comment.
@mdonnalley, @peternhale fyi ^
There was a problem hiding this comment.
How about?
return !['development', 'test'].some(mode => mode === (process.env.NODE_ENV ?? '')
There was a problem hiding this comment.
I think we can go even simpler. How about?
return !['development', 'test'].reduce((prev, curr) => curr === (process.env.NODE_ENV ?? '') || prev, false)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isProdreturns false ifprocess.env.NODE_ENVis eitherdevelopmentortestFixes #367