Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

fix: add support for experimentalDecorators and emitDecoratorMetadata from tsconfig.json #97

Merged
merged 1 commit into from Jun 8, 2020

Conversation

rustyconover
Copy link
Contributor

Add support for two additional ts flags from tsconfig.json.

@salesforce-cla
Copy link

salesforce-cla bot commented Feb 1, 2020

Thanks for the contribution! Before we can merge this, we need @rustyconover to sign the Salesforce.com Contributor License Agreement.

… from tsconfig.json

Add support for two additional ts flags from tsconfig.json.
@codecov
Copy link

codecov bot commented Feb 1, 2020

Codecov Report

Merging #97 into master will decrease coverage by 66.81%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #97       +/-   ##
========================================
- Coverage   66.81%    0%   -66.82%     
========================================
  Files           7     2        -5     
  Lines         452    12      -440     
  Branches      127     3      -124     
========================================
- Hits          302     0      -302     
+ Misses        101    12       -89     
+ Partials       49     0       -49
Impacted Files Coverage Δ
src/index.ts 0% <0%> (-100%) ⬇️
src/debug.ts 0% <0%> (-45.46%) ⬇️
src/util.ts
src/plugin.ts
src/config.ts
src/command.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c800f2...ef36c8b. Read the comment docs.

@AuHau
Copy link

AuHau commented Mar 18, 2020

This would be very welcomed because without this it is not possible to use oclif for application which uses decorators.

Copy link
Contributor

@RasPhilCo RasPhilCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄 would love to see your cli using this if you feel like sharing a link

@RasPhilCo RasPhilCo merged commit 89bb82b into oclif:master Jun 8, 2020
@AuHau
Copy link

AuHau commented Jun 9, 2020

Nice! Thanks :-)

I am wrapping web-server which uses https://github.com/RobinBuschmann/sequelize-typescript for model definitions.

Not sure if this will make much sense for you, but here is the repo: https://github.com/rsksmart/rif-marketplace-cache

Btw. I have found workaround for this, where I run the bin/run with my instance of ts-node which uses the correct config, but this will be definitely much more user-friendly :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants