This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
Fix: do not cache require, require is already cached in NodeJS by design #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an additional caching layer (deps.ts) on top of that has no value and only breaks JS packaging tools such as webpack/rollup.
|
I see the build failed due to |
|
Add eslint ignore statements should and I can merge it! |
…lint not detecting ts files as valid js modules.
|
Done! I added the ignore statement for the whole file as most of the includes are affected by this. |
oclif-bot
added a commit
that referenced
this pull request
Aug 7, 2020
## [5.4.10](v5.4.9...v5.4.10) (2020-08-07) ### Bug Fixes * do not cache require, require is already cached in NodeJS by design ([#194](#194)) ([99b9466](99b9466))
|
🎉 This PR is included in version 5.4.10 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
deps.tsseveral dependencies are being cached to a local object. As NodeJS by design caches require calls the caching done indeps.tsdoes not offer performance benefit. Instead it causes problems when usingcli-uxtogether with webpack or rollup for which at this time there is no simple fix.I think it might be better to replace all calls to deps.ts with standard require calls, but as that is a bigger change I first wanted to check if that is appriciated before I will start making those changes :)