Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding instructions on how to use ERC725 in the CodeExamples file #1672

Merged
merged 9 commits into from Dec 22, 2022

Conversation

jamiehewitt15
Copy link
Member

Fixes #1668

Changes proposed in this PR:

  • Adding instructions on how to use ERC725 in the CodeExamples file

bogdanfazakas
bogdanfazakas previously approved these changes Dec 22, 2022
package.json Outdated Show resolved Hide resolved
test/integration/CodeExamples.test.ts Outdated Show resolved Hide resolved
test/integration/CodeExamples.test.ts Show resolved Hide resolved
@bogdanfazakas bogdanfazakas dismissed their stale review December 22, 2022 11:59

think we need to address the issue above first

@codeclimate
Copy link

codeclimate bot commented Dec 22, 2022

Code Climate has analyzed commit 39ac4a4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 80.0% (0.0% change).

View more on Code Climate.

Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamiehewitt15 jamiehewitt15 merged commit 1af7835 into main Dec 22, 2022
@jamiehewitt15 jamiehewitt15 deleted the issue-#1668-erc725-readme branch December 22, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For gtc hackathon (and generally), write short readme on ocean.js for ERC725 / SBTs
2 participants