Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ve mainnet deployment #716

Merged
merged 4 commits into from Sep 23, 2022
Merged

Conversation

alexcos20
Copy link
Member

Fixes # .

Changes proposed in this PR:

@@ -0,0 +1,63 @@
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.12;

Check warning

Code scanning / Slither

Incorrect versions of Solidity

Pragma version^0.8.12 (contracts/ve/SmartWalletChecker.sol#2) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
* @param _status The status to allow the manager
*/
function setAllowedContract(
address _contract,

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Parameter SmartWalletChecker.setAllowedContract(address,bool)._contract (contracts/ve/SmartWalletChecker.sol#40) is not in mixedCase
* @param _status The status to allow the manager
*/
function setManager(
address _manager,

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Parameter SmartWalletChecker.setManager(address,bool)._manager (contracts/ve/SmartWalletChecker.sol#25) is not in mixedCase
*/
function setManager(
address _manager,
bool _status

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Parameter SmartWalletChecker.setManager(address,bool)._status (contracts/ve/SmartWalletChecker.sol#26) is not in mixedCase
*/
function setAllowedContract(
address _contract,
bool _status

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Parameter SmartWalletChecker.setAllowedContract(address,bool)._status (contracts/ve/SmartWalletChecker.sol#41) is not in mixedCase
* @param _address The address to check
*/
function check (
address _address

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Parameter SmartWalletChecker.check(address)._address (contracts/ve/SmartWalletChecker.sol#54) is not in mixedCase
@alexcos20 alexcos20 self-assigned this Sep 23, 2022
@alexcos20 alexcos20 merged commit 501bc86 into main Sep 23, 2022
@alexcos20 alexcos20 deleted the feature/ve_mainnet_deployment branch September 23, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant