Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watcher process leaks if using old version of HTTPoison #73

Closed
chazsconi opened this issue Oct 9, 2019 · 2 comments · Fixed by #74
Closed

Watcher process leaks if using old version of HTTPoison #73

chazsconi opened this issue Oct 9, 2019 · 2 comments · Fixed by #74

Comments

@chazsconi
Copy link
Collaborator

chazsconi commented Oct 9, 2019

Due to edgurgel/httpoison#375 (which I created a PR to fix, and is now merged) if you use HTTPoison < v1.6.1 you will have a process leak when using watches whenever a GONE event is received from K8S.

Therefore should Kazan's deps be changed to force using this version or later of HTTPoison, or should this just be warned about in the docs?

I'm happy to create a PR for either option.

@obmarg
Copy link
Owner

obmarg commented Oct 9, 2019

Ah nice - I saw similar problems in a project I had based on HTTPoison a few years ago. Good to see someone fixing it.

I think it'd be fine to require > HTTPoison >= 1.6.1 - I'm assuming there's no breaking API changes, and people can always use an override: true dep if they really need an older verson.

@chazsconi
Copy link
Collaborator Author

chazsconi commented Oct 9, 2019

OK - PR created. #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants