Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive: using a type alias to point to the new location of a type is not a breaking change #215

Closed
obi1kenobi opened this issue Dec 9, 2022 · 0 comments · Fixed by #330

Comments

@obi1kenobi
Copy link
Owner

I am not sure if it is the same underlying issue but supporting type aliases is more important. They allow us to deprecate APIs which we use quite extensively. I am not a fan of renaming imports myself so if you have to pick which one to implement first, I'd vote for type aliases :)

Originally posted by @thomaseizinger in libp2p/rust-libp2p#2647 (comment)

If an earlier version had a type (struct, enum, etc.) by some name, and the new version moves that type elsewhere but leaves a type alias in its place, that is not a breaking change. Currently, this scenario isn't detected, and we should update our simulated import resolution logic to cover this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant