Migrate metadata from setup.py to setup.cfg #863
Conversation
| name = oauthlib | ||
| version = attr: oauthlib.__version__ | ||
| author = The OAuthlib Community | ||
| author_email = idan@gazit.me |
There was a problem hiding this comment.
we can use the email of two current active maintainer here
There was a problem hiding this comment.
@JonathanHuot Your call on changing the Author email address?
setup.cfg
Outdated
| license_files = LICENSE | ||
| long_description = file: README.rst | ||
| long_description_content_type = text/x-rst | ||
| maintainer = Ib Lundgren |
There was a problem hiding this comment.
| maintainer = Ib Lundgren | |
| maintainer = Asif Saif Uddin, Jonathan Huot |
There was a problem hiding this comment.
@JonathanHuot Do you want your email address published as a Maintainer?
| run: python setup.py sdist bdist_wheel | ||
| run: pip install build wheel | ||
| - name: Build Python package | ||
| run: python -m build |
There was a problem hiding this comment.
do this provide both sdist bdist_wheel at once?
There was a problem hiding this comment.
There was a problem hiding this comment.
i saw that before, but just asking out of curiosity, do that provide same functionalities in a simpler new way?
There was a problem hiding this comment.
build is the PyPA default tool for doing Python builds without a setup.py but there are many other ways to do builds. I suggest we look at the build results to see if they fit our purposes.
setup.cfg
Outdated
| long_description = file: README.rst | ||
| long_description_content_type = text/x-rst | ||
| maintainer = Asif Saif Uddin, Jonathan Huot | ||
| maintainer_email = ib.lundgren@gmail.com |
There was a problem hiding this comment.
| maintainer_email = ib.lundgren@gmail.com | |
| maintainer_email = auvipy@gmail.com |
Closes #862
buildbecause runningsetup.pyis deprecated for security reasons #862Created using https://pypi.org/project/setuptools-py2cfg plus manual modifications.
https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use
After this pull request is tested and merged, I can do a follow-up PR like...
PEP 621: Migrate settings from setup.cfg into pyproject.toml
Migrate settings from
setup.cfgintopyproject.tomlusing ini2toml to do the file conversion and running pyproject-fmt and then validate-pyproject in pre-commit to validate the results.