Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh id tokens #751

Closed
nsklikas opened this issue Mar 8, 2021 · 1 comment · Fixed by #752
Closed

Refresh id tokens #751

nsklikas opened this issue Mar 8, 2021 · 1 comment · Fixed by #752
Labels
Bug OAuth2-Provider This impact the provider part of OAuth2

Comments

@nsklikas
Copy link
Contributor

nsklikas commented Mar 8, 2021

Describe the feature
It is not possible with the current implementation to issue ID tokens on refresh.

Additional context

The refresh token modifiers (https://github.com/oauthlib/oauthlib/blob/master/oauthlib/oauth2/rfc6749/grant_types/refresh_token.py#L66) take only 1 argument while the authorization code modifiers take 3 (https://github.com/oauthlib/oauthlib/blob/master/oauthlib/oauth2/rfc6749/grant_types/authorization_code.py#L308).

The modifier function add_id_token used to add id tokens in the OIDC token response is not compatible with the refresh token's modifier interface.

I see no reason to have that behavior. If there are no objections I can go ahead and create a PR that will harmonize the modifier arguments and add ID tokens to the refresh token responses for OIDC out of the box.

@thedrow thedrow added Bug OAuth2-Provider This impact the provider part of OAuth2 labels Mar 10, 2021
@thedrow
Copy link
Collaborator

thedrow commented Mar 10, 2021

Please do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug OAuth2-Provider This impact the provider part of OAuth2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants