Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client side implementation for PKCE #741

Closed
amans330 opened this issue Nov 10, 2020 · 5 comments · Fixed by #786
Closed

Add client side implementation for PKCE #741

amans330 opened this issue Nov 10, 2020 · 5 comments · Fixed by #786
Milestone

Comments

@amans330
Copy link
Contributor

Client-side PKCE for OAuth2 RFC 7636 is required for applications to have secure communication with the authorization server. OAuth 2.0 public clients utilizing the Authorization Code Grant are susceptible to the authorization code interception attack. PKCE mitigates this issue by adding an extra challenge/verifier parameter with each request it sends to the server.

@amans330
Copy link
Contributor Author

I am working on this feature. Feel free to get in touch for any comments.

@amans330
Copy link
Contributor Author

Created PR --> #743

@sharonbz
Copy link

This looks like a security issue, is it going fo be fixed in the next release?
This is similar to CVE-2020-7692 that was assigned to the google-oauth-java-client package.

@amans330
Copy link
Contributor Author

I have raised the above PR. Should be fixed when it's approved.

@auvipy auvipy added this to the 3.2.0 milestone Dec 13, 2021
@auvipy auvipy linked a pull request Dec 13, 2021 that will close this issue
@auvipy auvipy closed this as completed Dec 13, 2021
@sarathsund
Copy link

hi, I do have the same issue in jupyterhub requirements dependencies. May i know in which release version this PR fix will be merged ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants