added 'verbose' flag to turn on logging for all http requests #82
+24
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I shape up the merge conflicts here, would this be merged? |
|
An alternative to logging is to use Set the |
| @@ -321,6 +328,8 @@ def create_http(_url = nil) | |||
| http_object.read_timeout = http_object.open_timeout = @options[:timeout] || 30 | |||
| http_object.open_timeout = @options[:open_timeout] if @options[:open_timeout] | |||
|
|
|||
| http_object.set_debug_output($stdout) if @options[:verbose] | |||
There was a problem hiding this comment.
how about:
case @options[:verbose]
when false, nil
nil
when true
http_object.set_debug_output($stdout)
else
http_object.set_debug_output(@options[:verbose])
end
|
@cloocher can we get a rebase here? I love the code. |
|
I am reopening it so as to trigger TravisCI. |
|
I am reopening it so as to trigger TravisCI. |
1 similar comment
|
I am reopening it so as to trigger TravisCI. |
|
@cloocher @kurioscreative @dbezborodovrp could any of you please rebase this PR? |
|
Updated: I love the tests too. ❤️ 😍 |
ch1ago
added a commit
that referenced
this pull request
Apr 28, 2016
|
I have reimplemented the improvement |
ch1ago
added a commit
that referenced
this pull request
Apr 28, 2016
ch1ago
added a commit
that referenced
this pull request
Apr 28, 2016
Reimplementing #82 - Debug Output Option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added 'verbose' flag to turn on logging for all http requests useful for debugging issues