Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Setup Rubocop #208

Merged
merged 12 commits into from Oct 31, 2021
Merged

🚨 Setup Rubocop #208

merged 12 commits into from Oct 31, 2021

Conversation

pboling
Copy link
Member

@pboling pboling commented Oct 31, 2021

  • Minimum required lint fixes
  • Remainder in .rubocop_todo.yml
  • Closes #205

Signed-off-by: Peter Boling peter.boling@gmail.com

- Minimum required lint fixes
- Remainder in .rubocop_todo.yml
- Closes #205

Signed-off-by: Peter Boling <peter.boling@gmail.com>
@pboling pboling self-assigned this Oct 31, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2021

Codecov Report

Merging #208 (e4dd2cd) into master (6182027) will increase coverage by 10.07%.
The diff coverage is 62.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #208       +/-   ##
===========================================
+ Coverage   29.62%   39.69%   +10.07%     
===========================================
  Files          65       38       -27     
  Lines        2363     1058     -1305     
===========================================
- Hits          700      420      -280     
+ Misses       1663      638     -1025     
Flag Coverage Δ
unittests 39.69% <62.14%> (+10.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/oauth/cli/base_command.rb 16.36% <0.00%> (ø)
lib/oauth/client/helper.rb 42.00% <33.33%> (+0.82%) ⬆️
lib/oauth/client/em_http.rb 34.09% <42.85%> (ø)
lib/oauth/request_proxy/net_http.rb 47.50% <44.44%> (ø)
lib/oauth/consumer.rb 27.65% <47.05%> (-0.39%) ⬇️
lib/oauth/client/net_http.rb 29.78% <50.00%> (ø)
...b/oauth/request_proxy/action_controller_request.rb 36.73% <50.00%> (ø)
lib/oauth/signature/hmac/sha1.rb 77.77% <50.00%> (ø)
lib/oauth/signature/hmac/sha256.rb 77.77% <50.00%> (ø)
lib/oauth/request_proxy/rest_client_request.rb 47.05% <57.14%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6182027...e4dd2cd. Read the comment docs.

Signed-off-by: Peter Boling <peter.boling@gmail.com>
Signed-off-by: Peter Boling <peter.boling@gmail.com>
Signed-off-by: Peter Boling <peter.boling@gmail.com>
Signed-off-by: Peter Boling <peter.boling@gmail.com>
Signed-off-by: Peter Boling <peter.boling@gmail.com>
Signed-off-by: Peter Boling <peter.boling@gmail.com>
Signed-off-by: Peter Boling <peter.boling@gmail.com>
Signed-off-by: Peter Boling <peter.boling@gmail.com>
Signed-off-by: Peter Boling <peter.boling@gmail.com>
Signed-off-by: Peter Boling <peter.boling@gmail.com>
Signed-off-by: Peter Boling <peter.boling@gmail.com>
@pboling pboling merged commit fec9a27 into master Oct 31, 2021
@pboling pboling deleted the issue/205-lock-rubocop-down branch October 31, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants