Action Controller support for PUT requests #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It surprises me that DELETE is not also generically supported? We appear to not require it, but... |
|
There was already test coverage for PUT that was IMHO wrong, I simply fixed it so I am not expecting the code coverage to change. |
xtagon
requested changes
Mar 28, 2021
| @@ -72,6 +72,10 @@ def parameters_for_signature | |||
| reject { |kv| kv[0] == 'oauth_signature'} | |||
| end | |||
|
|
|||
| def raw_post_signature | |||
There was a problem hiding this comment.
IMO this should be raw_post_signature? with a ? for convention (it returns a boolean). Minor nitpick though
| @@ -109,7 +109,7 @@ def test_that_proxy_simple_post_request_works_with_mixed_params | |||
| def test_that_proxy_simple_put_request_works_with_mixed_params | |||
| request_proxy = request_proxy(:put, {'key'=>'value'}, {'key2'=>'value2'}) | |||
|
|
|||
| expected_parameters = [["key", "value"]] | |||
| expected_parameters = [["key", "value"],["key2", "value2"]] | |||
There was a problem hiding this comment.
Yeah I see what you mean, the original test looks wrong and this fixes it. LGTM.
Most of the other request proxies support PUT requests and we need this gem to also support it for Action Controller. This addresses issue #180 It includes the modified Action Controller proxy and fixes the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the other request proxies support PUT
requests and we need this gem to also support it
for Action Controller. This addresses issue #180
It includes the modified Action Controller proxy
and fixes the tests.