Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase default timeout to 60 seconds #163

Merged

Conversation

smaeda-ks
Copy link
Contributor

From the Net::HTTP Class, the default values are:

Or, is there any specific reason this library wants to set 30 seconds over that default values?

Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the same defaults as Net::HTTP makes sense.

Approved, except the test suite isn't passing.

Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix specs

@smaeda-ks smaeda-ks force-pushed the smaeda-ks/increase-default-timeout branch from 17eb01f to 51756a4 Compare January 20, 2021 18:52
@smaeda-ks
Copy link
Contributor Author

Thanks @pboling, just merged master branch and now tests are passing.

Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pboling pboling merged commit 59be6bc into oauth-xx:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants