Require plaintext signature method #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en and Travis CI default (v2.5.1) is probably broken too.
|
@thejamespinto LGTM, second pair of eyes? |
|
+1. Thank you @confiks! |
|
+1 to this; we're having the same issue. |
pboling
requested changes
Jan 20, 2021
|
I'm not going to do this after more than four years. |
|
That's quite reasonable! New management is going to handle it still. ;) |
|
Nice 👍 Please keep in mind that this PR included a explicit version choice of rubygems |
|
Ah, but you removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the plaintext signature class is not
require'd by default, and cannot be used without explicitly requiring it. This has historically been so, and the tests go out of their way to manually require the class: https://github.com/oauth-xx/oauth-ruby/blob/705ae93/test/units/test_net_http_client.rb#L28. I have no idea why this choice has been made.Last year in issue #76 some users bumped their head against this. This should either be documented, or the class should just be required.
This pull request adds the require statement and removes all the require statements from the tests.
I also modified travis.yml to use a specific rubygems version, because master is probably broken (rubygems/rubygems#1679) and it can break in the future. The Travis CI default (v2.5.1) unfortunately is broken as well (rubygems/rubygems#1223).