Flaky TestConnectorTestSuite/TestConnect

[ptrus]

Not really sure why, but the TestConnectorTestSuite/TestConnect from go/p2p/peermgmt/connector_test.go sometimes (1) fails on CI:

    connector_test.go:145:
        	Error Trace:	/workdir/go/p2p/peermgmt/connector_test.go:145
        	            				/workdir/go/p2p/peermgmt/asm_amd64.s:1571
        	Error:      	Should be true
        	Test:       	TestConnectorTestSuite/TestConnect

Probably the local connect fails for some reason? Didn't look in-depth, but couldn't reproduce it in few tries locally.

One reason that is hard to debug this is that the unit tests don't have an appropriate logger setup. Although the called function uses a logger to report errors, this is not shown in the Buildkite output. Should probably look into automatically setting up an appropriate logger instance for all unit tests.