Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/host: Fix env vars for tests #4714

Open
mitjat opened this issue Apr 29, 2022 · 0 comments
Open

go/runtime/host: Fix env vars for tests #4714

mitjat opened this issue Apr 29, 2022 · 0 comments
Labels
c:bug Category: bug c:testing Category: testing p:2 Priority: desired feature

Comments

@mitjat
Copy link
Contributor

mitjat commented Apr 29, 2022

The test in sandbox_test.go only runs if OASIS_TEST_RUNTIME_HOST_BUNDLE_PATH is defined. However, we never set that in CI or elsewhere in the repo; we only set the older OASIS_TEST_RUNTIME_HOST_RUNTIME_PATH in CI here). That's probably a TODO from the migration to bundles.

The test running script (test_and_coverage.sh) needs to be updated to generate a bundle (oasis-node debug bundle) and set the right env variable.

@mitjat mitjat added p:2 Priority: desired feature c:testing Category: testing c:bug Category: bug labels Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:testing Category: testing p:2 Priority: desired feature
Projects
None yet
Development

No branches or pull requests

3 participants
@mitjat and others