Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a staking genesis sanity check to ensure debonding interval > 0 #4663

Open
ptrus opened this issue Apr 12, 2022 · 0 comments
Open

Add a staking genesis sanity check to ensure debonding interval > 0 #4663

ptrus opened this issue Apr 12, 2022 · 0 comments

Comments

@ptrus
Copy link
Member

ptrus commented Apr 12, 2022

The liveness statistics code assumes that the node status for all runtime nodes from the previous epoch exists and can be queried:

status, err := regState.NodeStatus(ctx, nodeID)
if err != nil {
return fmt.Errorf("failed to retrieve status for node %s: %w", nodeID, err)
}

This effetely means that staking deboning interval needs to be >0.

This doesn't affect any real network deployments, as there the staking debonding interval is configured.
Still, it would be nice to have a sanity check to catch this potential misconfiguration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant