Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug logging spam when syncing runtime's rounds #4401

Open
tjanez opened this issue Dec 16, 2021 · 1 comment
Open

Remove debug logging spam when syncing runtime's rounds #4401

tjanez opened this issue Dec 16, 2021 · 1 comment
Labels
c:runtime Category: runtime

Comments

@tjanez
Copy link
Member

tjanez commented Dec 16, 2021

SUMMARY

Remove debug logging spam when syncing runtime's rounds.

Currently, a debug message is emitted for each round that is being prepared for syncing:


... trimmed ...

{"awaiting_retry":"outstanding_mask{state-root}","caller":"node.go:1255","level":"debug","module":"worker/storage/committee","msg":"preparing round sync","outstanding_mask":"outstanding_mask{}","round":20134,"runtime_id":"00000000000000000000000000000000000000000000000072c8215e60d5bca7","ts":"2021-12-16T10:52:57.539461527Z"}
{"awaiting_retry":"outstanding_mask{state-root}","caller":"node.go:1255","level":"debug","module":"worker/storage/committee","msg":"preparing round sync","outstanding_mask":"outstanding_mask{}","round":20135,"runtime_id":"00000000000000000000000000000000000000000000000072c8215e60d5bca7","ts":"2021-12-16T10:52:57.539484704Z"}
{"awaiting_retry":"outstanding_mask{state-root}","caller":"node.go:1255","level":"debug","module":"worker/storage/committee","msg":"preparing round sync","outstanding_mask":"outstanding_mask{}","round":20136,"runtime_id":"00000000000000000000000000000000000000000000000072c8215e60d5bca7","ts":"2021-12-16T10:52:57.539514816Z"}
{"awaiting_retry":"outstanding_mask{state-root}","caller":"node.go:1255","level":"debug","module":"worker/storage/committee","msg":"preparing round sync","outstanding_mask":"outstanding_mask{}","round":20137,"runtime_id":"00000000000000000000000000000000000000000000000072c8215e60d5bca7","ts":"2021-12-16T10:52:57.539533801Z"}
{"awaiting_retry":"outstanding_mask{state-root}","caller":"node.go:1255","level":"debug","module":"worker/storage/committee","msg":"preparing round sync","outstanding_mask":"outstanding_mask{}","round":20138,"runtime_id":"00000000000000000000000000000000000000000000000072c8215e60d5bca7","ts":"2021-12-16T10:52:57.539547648Z"}
{"awaiting_retry":"outstanding_mask{state-root}","caller":"node.go:1255","level":"debug","module":"worker/storage/committee","msg":"preparing round sync","outstanding_mask":"outstanding_mask{}","round":20139,"runtime_id":"00000000000000000000000000000000000000000000000072c8215e60d5bca7","ts":"2021-12-16T10:52:57.539561767Z"}

... trimmed ...

For example, in case there are 100k rounds to be synced, it would emit 100k debug log messages at once.

ISSUE TYPE
  • Feature Idea
@tjanez tjanez added the c:runtime Category: runtime label Dec 16, 2021
@Yawning
Copy link
Contributor

Yawning commented Jan 31, 2022

Isn't the solution to this, to not log at the debug level?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:runtime Category: runtime
Projects
None yet
Development

No branches or pull requests

2 participants