Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making deferred InitChain events non consensus-breaking #4389

Open
kostko opened this issue Dec 7, 2021 · 0 comments
Open

Consider making deferred InitChain events non consensus-breaking #4389

kostko opened this issue Dec 7, 2021 · 0 comments
Labels
c:breaking/consensus Category: breaking consensus changes c:consensus/tendermint Category: Tendermint-based consensus

Comments

@kostko
Copy link
Member

kostko commented Dec 7, 2021

Currently events emitted from InitChain handlers are deferred until the first block by serializing them into storage. Even though event changes are otherwise not consensus-breaking, handling them like this makes them so as the initial state root depends on their serialization. It would be great to change this to avoid unexpected breaking changes.

@kostko kostko added c:consensus/tendermint Category: Tendermint-based consensus c:breaking/consensus Category: breaking consensus changes labels Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes c:consensus/tendermint Category: Tendermint-based consensus
Projects
None yet
Development

No branches or pull requests

1 participant