Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for Node 12 #837

Closed
fargito opened this issue Oct 12, 2022 · 7 comments
Closed

Deprecation warning for Node 12 #837

fargito opened this issue Oct 12, 2022 · 7 comments

Comments

@fargito
Copy link

fargito commented Oct 12, 2022

Hello, and thanks a lot for this awesome action!

I have started encountering this warning in my CI lately:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: nwtgck/actions-netlify

Is the update to Node 16 on the roadmap?

@nwtgck
Copy link
Owner

nwtgck commented Oct 12, 2022

Thanks for notifying me.

@manuelfidalgo
Copy link

manuelfidalgo commented Oct 14, 2022

Hi @nwtgck , greetings from Spain!
thanks a lot for this action, I use it to provide a summary of test results.
There is also a warning regarding using set-output you can read more in GitHub Actions: Deprecating save-state and set-output commands
I think you only need to update @actions/core to v1.10.0 in package.json. If you want, I can send you a PR

@nwtgck
Copy link
Owner

nwtgck commented Oct 14, 2022

Thank you so much for the investigation! Bumping up libraries is repository maintainer's task for security reason. I'll try.

@nwtgck
Copy link
Owner

nwtgck commented Oct 14, 2022

This should be resolved by #827.

I released 1.2.4.

before:
image

1.2.4:
image

@fargito
Copy link
Author

fargito commented Oct 18, 2022

I can confirm, the issue is resolved on my end as well. Thanks a lot!

@fargito fargito closed this as completed Oct 18, 2022
@kfiven
Copy link

kfiven commented Nov 8, 2022

@nwtgck Hi, I am still getting the Node 12 error on v1.2.4.

@kfiven
Copy link

kfiven commented Nov 8, 2022

Looks like you need to update this at https://github.com/nwtgck/actions-netlify/blob/develop/action.yml#L54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants