{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":373012605,"defaultBranch":"main","name":"rails","ownerLogin":"nvasilevski","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2021-06-02T02:09:05.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/5512772?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1711329905.0","currentOid":""},"activityList":{"items":[{"before":"575d16577b00a0be3c0ac88a8d2086705afa1d87","after":"3df4d6927d18436718561901c7cdb4ff7065f4e6","ref":"refs/heads/add-composite-association-pk-fk-to-changelog","pushedAt":"2024-03-25T12:39:31.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"},"commit":{"message":"Add CHANGELOG entries for association composite primary and foreign keys","shortMessageHtmlLink":"Add CHANGELOG entries for association composite primary and foreign keys"}},{"before":null,"after":"575d16577b00a0be3c0ac88a8d2086705afa1d87","ref":"refs/heads/add-composite-association-pk-fk-to-changelog","pushedAt":"2024-03-25T01:25:05.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"},"commit":{"message":"Add CHANGELOG entries for association composite primary and foreign keys","shortMessageHtmlLink":"Add CHANGELOG entries for association composite primary and foreign keys"}},{"before":"06c83d93cf0ea28cda553830023717204eb77b9f","after":"16ff9afb2e78346e51b8969b76fc6afcba69d860","ref":"refs/heads/main","pushedAt":"2023-12-26T15:08:32.000Z","pushType":"push","commitsCount":6301,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"},"commit":{"message":"Merge pull request #50275 from seanpdoyle/polymorphic-rename\n\nProvide guidance for renaming classes in polymorphic associations [ci skip]","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2026994953\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rails/rails/issues/50275\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rails/rails/pull/50275/hovercard\" href=\"https://github.com/rails/rails/pull/50275\">rails#50275</a> from seanpdoyle/polymorphic-rename"}},{"before":"2342f398456609255359bada019b8ec746c491ef","after":null,"ref":"refs/heads/disallow-assertionless-tests-in-active-model","pushedAt":"2023-06-09T22:00:34.425Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"}},{"before":"02d8b6165f9d6cebcc0c61930ff7ddbb055c8e10","after":"2342f398456609255359bada019b8ec746c491ef","ref":"refs/heads/disallow-assertionless-tests-in-active-model","pushedAt":"2023-04-26T14:51:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"},"commit":{"message":"Disallow assertionless tests in Active Model\n\nThis commit adds an `after_teardown` logic to the `activemodel` test\nsuite which ensures that performed test incremented the `assertions`\ncounter at least once. Otherwise it raises an `AssertionlessTest` error.\n\nThis leads to a requirement for tests to be verbose about assertions\neven if technically it may not be needed. For example a test like:\n```ruby\ndef test_submitting_a_review_doesnt_raise\n  review.submit!\nend\n```\n\nwill have to at least become\n\n```ruby\ndef test_submitting_a_review_doesnt_raise\n  assert_nothing_raised { review.submit! }\nend\n```\n\nor preferably it should perform a semantically meaningful assertion\nthat will imply not exception being raised, for example:\n\n```ruby\ndef test_submitting_a_review_doesnt_raise\n  review.submit!\n\n  assert_not_nil review.submitted_at\nend\n```\n\nOverall while the requirement is being defensive it improves\nreadability of the tests along with ensuring that we will never\nend up having tests that test nothing.","shortMessageHtmlLink":"Disallow assertionless tests in Active Model"}},{"before":"1142342a2a4650de7fadaa203dc02ac4e83c4e75","after":"02d8b6165f9d6cebcc0c61930ff7ddbb055c8e10","ref":"refs/heads/disallow-assertionless-tests-in-active-model","pushedAt":"2023-04-26T14:51:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"}},{"before":"acf43caa4f320d5445da3f4c9f37680818b4902d","after":"1142342a2a4650de7fadaa203dc02ac4e83c4e75","ref":"refs/heads/disallow-assertionless-tests-in-active-model","pushedAt":"2023-04-26T14:41:25.000Z","pushType":"push","commitsCount":0,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"}},{"before":"b80093c9cf5a91f6f849183c7265c6cd9e675ec4","after":"acf43caa4f320d5445da3f4c9f37680818b4902d","ref":"refs/heads/disallow-assertionless-tests-in-active-model","pushedAt":"2023-04-25T17:42:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"}},{"before":"b3e40c0abc4f088d15229c1b60a4d5447836bd28","after":"b80093c9cf5a91f6f849183c7265c6cd9e675ec4","ref":"refs/heads/disallow-assertionless-tests-in-active-model","pushedAt":"2023-04-25T17:05:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"}},{"before":"b34e35a5915a1dbc2fd51dd18bd1ce53495f3a52","after":"b3e40c0abc4f088d15229c1b60a4d5447836bd28","ref":"refs/heads/disallow-assertionless-tests-in-active-model","pushedAt":"2023-04-25T17:01:40.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"}},{"before":null,"after":"b34e35a5915a1dbc2fd51dd18bd1ce53495f3a52","ref":"refs/heads/disallow-assertionless-tests-in-active-model","pushedAt":"2023-04-25T16:54:26.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"}},{"before":"3e8c18bea9e3a07249a30b238f03665679d943b1","after":null,"ref":"refs/heads/active-model-collection-attribute-with-broken-tests","pushedAt":"2023-03-31T19:41:29.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"}},{"before":"53082b7076666607be26b700f91d12f01b924c6d","after":null,"ref":"refs/heads/do-not-write-to-store-unchanged-value","pushedAt":"2023-03-31T19:40:55.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"}},{"before":"e8b885487b8b49ed65a1b9bdd9fbc0d60a45b6c3","after":null,"ref":"refs/heads/associations-respect-query-constraints","pushedAt":"2023-03-31T19:40:28.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"}},{"before":"df55d20b18be8ded8941ae4422de530e8c6f0e1b","after":null,"ref":"refs/heads/support-row-constructor-querying","pushedAt":"2023-03-31T19:40:25.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"}},{"before":"6a35878dbbd2c65ab8b15faf77a0fb03518b0e06","after":null,"ref":"refs/heads/composite-primary-index","pushedAt":"2023-03-16T15:14:41.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"nvasilevski","name":"Nikita Vasilevsky","path":"/nvasilevski","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5512772?s=80&v=4"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEHo2H0gA","startCursor":null,"endCursor":null}},"title":"Activity · nvasilevski/rails"}