Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite redirection when using qs after nuxt 3.11 #27059

Closed
Rigo-m opened this issue May 4, 2024 · 3 comments
Closed

Infinite redirection when using qs after nuxt 3.11 #27059

Rigo-m opened this issue May 4, 2024 · 3 comments

Comments

@Rigo-m
Copy link
Contributor

Rigo-m commented May 4, 2024

Environment

Netlify, various nuxt versions, check repo

Reproduction

https://github.com/Rigo-m/test-query-netlify

Describe the bug

Up until nuxt 3.10, integration with qs (which is needed for deep objects handling in query, e.g.: handling instantsearch filters state) works flawlessly in netlify.
From 3.11 onwards, there is an infinite redirection happening when the query values contains spaces.
I think this is happening because %20 gets transformed to + which gets re-transformed to %20 by qs, but I'm not sure.
I'm also not sure if this is an upstream issue with nitro (paging @pi0 )

Here relevant netlify links:

Nuxt 3.11.2 with qs in router-options
https://test-nuxt-query-netlify.netlify.app/?test=erba%20vita

Nuxt 3.10.2 with qs in router-options

https://nuxt-310--test-nuxt-query-netlify.netlify.app/?test=erba%20vita

Nuxt 3.11.2 without qs in router-options

https://noqs--test-nuxt-query-netlify.netlify.app/?test=erba%20vita

Additional context

No response

Logs

No response

Copy link
Member

This has been resolved on the nightly branch and the fix is incoming in v3.12

@danielroe danielroe closed this as not planned Won't fix, can't repro, duplicate, stale May 4, 2024
@Rigo-m
Copy link
Contributor Author

Rigo-m commented May 4, 2024

Thanks Daniel! Can you point me to the PR fixing this? Curious about what was happening under the hood
Nevermind, found it :)

@manniL
Copy link
Member

manniL commented May 5, 2024

For all ppl interested, it is #27016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants