Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): do not override inferred type of <NuxtPage> #18495

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #12395

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We were using an older format for the type of <NuxtPage>; this PR lets TS infer the type of the component (and removes a double type-definition via the router plugin).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Jan 24, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe requested a review from pi0 January 24, 2023 21:45
@vercel vercel bot temporarily deployed to Preview January 24, 2023 21:49 Inactive
@danielroe danielroe merged commit 9751c9d into main Jan 25, 2023
@danielroe danielroe deleted the fix/nuxt-page-props branch January 25, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prop completion does not work for <NuxtPage>
1 participant