fix(utils): serializeFunction fails with certain functions
#8780
+78
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A function shorthand with certain statements inside failed to serialize properly using serializeFunction. The issue was due to the replacement patterns not considering there being a space between the function name and the parenthesis before the arguments. Changed the simple string pattern to regexp to be able to match any number of whitespace characters between those. Also changed the test file to not be transformed by babel-jest as that has affected the input passed to "serializeFunction" and made some tests invalid. For example, the new test didn't even fail with babel-jest as it was transforming the test input in a way that made it pass. Resolves #8779
Codecov Report
@@ Coverage Diff @@
## dev #8780 +/- ##
=======================================
Coverage 66.03% 66.03%
=======================================
Files 92 92
Lines 4013 4013
Branches 1105 1105
=======================================
Hits 2650 2650
Misses 1097 1097
Partials 266 266
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pi0
reviewed
Feb 7, 2021
pi0
changed the title
serializeFunction fails with certain functions
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A function shorthand with certain statements inside failed to
serialize properly using serializeFunction.
Resolves #8779
Types of changes
Description
The issue was due to the replacement patterns not considering there being
a space between the function name and the parenthesis before the
arguments.
Changed the simple string pattern to regexp to be able to match any
number of whitespace characters between those.
Also changed the test file to not be transformed by babel-jest as that
has affected the input passed to "serializeFunction" and made some tests
invalid. For example, the new test didn't even fail with babel-jest as
it was transforming the test input in a way that made it pass.
Checklist: