Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modern): missing nomodule on script tag of legacy bundles #7919

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Aug 14, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Related to #7918

Normally, we should have 1:1 mapping between legacy and modern bundle files, but there're some edge cases that legacy bundle doesn't have a modern bundle, this pr is adding noModule to this kind of bundle so that legacy bundle won't be loaded in modern browsers.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2020

Codecov Report

Merging #7919 into dev will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7919   +/-   ##
=======================================
  Coverage   68.92%   68.92%           
=======================================
  Files          91       91           
  Lines        3846     3846           
  Branches     1041     1041           
=======================================
  Hits         2651     2651           
  Misses        971      971           
  Partials      224      224           
Flag Coverage Δ
#unittests 68.92% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/vue-renderer/src/renderers/modern.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4d420...f6648f2. Read the comment docs.

@pi0
Copy link
Member

pi0 commented Aug 14, 2020

azure failure is random :(

@pi0 pi0 merged commit 68b9183 into dev Aug 14, 2020
@pi0 pi0 deleted the fix-nomodule branch August 14, 2020 21:59
@pi0 pi0 mentioned this pull request Aug 14, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants