Skip to content

examples(tailwindcss-purgecss) : Update tailwindcss 0.6 to 1.6. using purgecss inside tailwindcss #7800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2020
Merged

examples(tailwindcss-purgecss) : Update tailwindcss 0.6 to 1.6. using purgecss inside tailwindcss #7800

merged 2 commits into from
Jul 30, 2020

Conversation

ChangJoo-Park
Copy link

@ChangJoo-Park ChangJoo-Park commented Jul 28, 2020

Summary when turn on purgecss

Hash: bfd08ab3c6a9a040152f
Version: webpack 4.44.0
Time: 4819ms
Built at: 2020. 07. 29. 오전 2:00:18
                         Asset       Size  Chunks                         Chunk Names
../server/client.manifest.json   6.42 KiB          [emitted]              
                      LICENSES  389 bytes          [emitted]              
                app.2c5c529.js   55.9 KiB       0  [emitted] [immutable]  app
        commons/app.fb27add.js    155 KiB       1  [emitted] [immutable]  commons/app
        pages/index.1623445.js   1.03 KiB       2  [emitted] [immutable]  pages/index
            runtime.fbf04a2.js   2.32 KiB       3  [emitted] [immutable]  runtime
 + 2 hidden assets
Entrypoint app = runtime.fbf04a2.js commons/app.fb27add.js app.2c5c529.js

Hash: d2a51fd5f61354dfa6a2
Version: webpack 4.44.0
Time: 1427ms
Built at: 2020. 07. 29. 오전 2:00:20
               Asset       Size  Chunks             Chunk Names
      pages/index.js   3.05 KiB       1  [emitted]  pages/index
           server.js   80.6 KiB       0  [emitted]  app
server.manifest.json  207 bytes          [emitted]  
 + 2 hidden assets
Entrypoint app = server.js server.js.map
ℹ Ready to run nuxt start                                                                                                                                                                                                                                                                  02:00:20
Done in 8.59s.

Summary when turn off purgecss

Hash: fbff12f7d58f1379259e
Version: webpack 4.44.0
Time: 8891ms
Built at: 2020. 07. 29. 오전 2:03:27
                         Asset       Size  Chunks                                Chunk Names
../server/client.manifest.json   6.42 KiB          [emitted]                     
                      LICENSES  389 bytes          [emitted]                     
                app.3175fe5.js    1.5 MiB       0  [emitted] [immutable]  [big]  app
        commons/app.fb27add.js    155 KiB       1  [emitted] [immutable]         commons/app
        pages/index.1623445.js   1.03 KiB       2  [emitted] [immutable]         pages/index
            runtime.fbf04a2.js   2.32 KiB       3  [emitted] [immutable]         runtime
 + 2 hidden assets
Entrypoint app [big] = runtime.fbf04a2.js commons/app.fb27add.js app.3175fe5.js

WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets: 
  app.3175fe5.js (1.5 MiB)

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (1000 KiB). This can impact web performance.
Entrypoints:
  app (1.65 MiB)
      runtime.fbf04a2.js
      commons/app.fb27add.js
      app.3175fe5.js


Hash: afc98b97a85423710abc
Version: webpack 4.44.0
Time: 4968ms
Built at: 2020. 07. 29. 오전 2:03:32
               Asset       Size  Chunks             Chunk Names
      pages/index.js   3.05 KiB       1  [emitted]  pages/index
           server.js   1.52 MiB       0  [emitted]  app
server.manifest.json  207 bytes          [emitted]  
 + 2 hidden assets
Entrypoint app = server.js server.js.map
ℹ Ready to run nuxt start                                                                                                                                                                                                                                                                  02:03:32
Done in 16.20s.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

- Using purgecss inside tailwindcss
- Migrate color classes
@pi0 pi0 requested review from atinux and TheAlexLichter July 29, 2020 09:29
@TheAlexLichter
Copy link
Member

LGTM! Only the linting issues have to be fixed 👍

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@pi0 pi0 merged commit 0a3e0cf into nuxt:dev Jul 30, 2020
@pi0 pi0 mentioned this pull request Jul 30, 2020
@ChangJoo-Park ChangJoo-Park deleted the tailwindcss-purgecss branch July 31, 2020 16:14
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants