Skip to content

fix(config): remove runtimeConfig string fallback #7421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2020
Merged

Conversation

kevinmarrec
Copy link
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Follows #7420

Since we check for string type in interpolate function, there is no need to fallback to empty string value ''.

It fixes the issue where false was transformed to ''.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

@codecov-commenter
Copy link

Codecov Report

Merging #7421 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7421   +/-   ##
=======================================
  Coverage   70.20%   70.20%           
=======================================
  Files          88       88           
  Lines        3679     3679           
  Branches     1007     1007           
=======================================
  Hits         2583     2583           
  Misses        889      889           
  Partials      207      207           
Flag Coverage Δ
#unittests 70.20% <100.00%> (ø)
Impacted Files Coverage Δ
packages/config/src/load.js 76.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cbcd59...d73b792. Read the comment docs.

@kevinmarrec kevinmarrec marked this pull request as ready for review May 27, 2020 13:10
@kevinmarrec kevinmarrec requested a review from pi0 May 27, 2020 13:10
@pi0 pi0 merged commit 618eb5f into dev May 27, 2020
@pi0 pi0 deleted the fix/runtime-config branch May 27, 2020 13:38
@pi0 pi0 mentioned this pull request Jun 10, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants