Skip to content

feat(vue-app): inject into plugins context #7212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2020
Merged

feat(vue-app): inject into plugins context #7212

merged 1 commit into from
Apr 14, 2020
+4 −0

Conversation

atinux
Copy link
Member

@atinux atinux commented Apr 13, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Plugins should also inject into context directly, a lot of modules are actually doing it.

TODO: tests

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

@galvez
Copy link

galvez commented Apr 13, 2020

Nice, never really missed this but it's good to know it'll be there.

@pi0 pi0 changed the title feat: inject in context feat(vue-app): inject into plugins context Apr 13, 2020
@pi0 pi0 merged commit 479e3ff into dev Apr 14, 2020
@pi0 pi0 deleted the feat/inject-in-context branch April 14, 2020 09:27
@atinux atinux mentioned this pull request Apr 21, 2020
Merged
@pi0 pi0 mentioned this pull request Jun 10, 2020
Merged
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvez galvez

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@atinux @galvez @pi0 @danielroe