fix(vue-app): error page layout not correctly applied in client rendering #6479
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galvez
previously approved these changes
Sep 28, 2019
Codecov Report
@@ Coverage Diff @@
## dev #6479 +/- ##
=======================================
Coverage 95.66% 95.66%
=======================================
Files 79 79
Lines 2701 2701
Branches 697 697
=======================================
Hits 2584 2584
Misses 101 101
Partials 16 16
Continue to review full report at Codecov.
|
pi0
approved these changes
Sep 29, 2019
pimlie
changed the title
pimlie
approved these changes
Sep 29, 2019
atinux
approved these changes
Sep 30, 2019
Merged
This was referenced Nov 12, 2019
This was referenced Apr 15, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
When error happened in client side rendering (like route change), layout in error.vue is not set.
Fix #2537, fix #5654 and fix nuxt/website-v2#231
Checklist: