Skip to content

fix(cli): server should not be initialized in nuxt build #6441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Sep 19, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

As server.js and vue-renderer are also be created in building, so server.ready and loaderResources will be executed which should only be executed in dev or start, this pr is for avoiding calling server ready and incorrect options change (like modern mode detect) which is only for server rendering.

@pi0 I removed _build in dev since it should be only for build. And I didn't see any where is using it, if there is any concern, I can add another filed in build.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Sorry, something went wrong.

@clarkdo clarkdo requested review from pi0 and a team September 19, 2019 21:08
@clarkdo clarkdo force-pushed the fix/missing-modern-build branch from d0c4840 to 8fc4751 Compare September 20, 2019 18:43

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@clarkdo clarkdo changed the title fix: modern build is not working with existed client dist fix(cli): server should not be initialized in nuxt build Sep 20, 2019
@pi0 pi0 merged commit 95e043f into dev Sep 20, 2019
@pi0 pi0 deleted the fix/missing-modern-build branch September 20, 2019 18:49
@codecov-io
Copy link

codecov-io commented Sep 20, 2019

Codecov Report

Merging #6441 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #6441   +/-   ##
=====================================
  Coverage   95.6%   95.6%           
=====================================
  Files         79      79           
  Lines       2684    2684           
  Branches     692     692           
=====================================
  Hits        2566    2566           
  Misses       101     101           
  Partials      17      17
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.7% <0%> (ø) ⬆️
#unit 92.28% <100%> (ø) ⬆️
Impacted Files Coverage Δ
packages/cli/src/commands/build.js 86.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f8564...7db98a7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants